BASH-10 add local icon reference for squirrel #592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to customize icons, they can not be remote. Adding
file://
to the beginning of the relative path will make it work locally."iconUrl": "file://resources/icon.ico"
npm run lint:js
for proper code formattingTest Cases
Replace
resources/icon.ico
fileRun
npm run package:windows
and make sure it runs properly and generates the files with the correct icon.