BASH-11 Open help link from config

[csduarte]

Description
This PR changes the behavior of the Help menu Learn More item to open the link that is defined for the helpLink property in the base.json file (src/common/config/base.json). This property can be overridden by defining the helpLink property in the override.json file (src/common/config/override.json).

• read and understood our Contributing Guidelines
• completed Mattermost Contributor Agreement
• executed npm run lint:js for proper code formatting

Test Cases
Add override values like this:

// Exampleoverride.js
{
  "1": {
    "helpLink": “http://test.helplink.com”
  }
}

Notes
includes BASH-20

[jasonblais]

I don't see any issues with this particular change. Makes a lot of sense. We allow overriding our help docs on the server-side.

Added the Pending label for now given the discussion in #586,

[jasonblais]

Actually, a question: what happens if helpLink is blank? Does it disappear from the Help Menu?

[csduarte]

@jasonblais It will open the link regardless, the value at the moment. So it would link to nothing, but the default is set MM

[jasonblais]

@csduarte @dmeza Would it be okay to ask that if the value is blank, then the option isn't shown in the Help Menu? Otherwise it would appear as a bug if nothing actually happens.

It's also consistent with how we handle help link settings server-side.

If you feel this is feature creep, let us know. We can also make this change ourselves.

[dmeza]

@jasonblais it should not be a problem to hide if the value is blank, sounds good to have consistency.

[dmeza]

@jasonblais @yuya-oc if help link is blank in config file, then the option isn't shown in the Help Menu:

[yuya-oc]

@dmeza Looks good. I think you haven't pushed the code yet. If you feel it's done, would you push it?

[dmeza]

@yuya-oc pushed.

[yuya-oc]

Thanks!

@jasonblais These are test builds.

• override with https://example.com: https://circleci.com/gh/yuya-oc/desktop/390#artifacts
• empty help link: https://circleci.com/gh/yuya-oc/desktop/391#artifacts

[jasonblais]

Thanks @yuya-oc and @dmeza , looks good! Should be good to merge after #586

PS: @yuya-oc the builds failed, anything to worry about?

[yuya-oc]

@jasonblais Nothing. Artifacts were correctly build.
Recently spectron tests are unstable somehow. I have been researching that, but I haven't found any good way yet.

[jasonblais]

#586 is now merged. @dmeza can you help with a rebase, resolving merge conflicts?

This should be otherwise good to merge unless @yuya-oc has any other comments.

[yuya-oc]

Due to merging of #586, please rebase the branch.

[dmeza]

@yuya-oc rebased and tested.

[yuya-oc]

https://circleci.com/gh/mattermost/desktop/1064#artifacts

The feature correctly works. By using following override.json, the link disappears.

{
  "1": {
    "helpLink": null
  }
}