Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore "gpu-process-crashed" event then output the log to console #647

Merged
merged 1 commit into from
Nov 8, 2017

Conversation

yuya-oc
Copy link
Contributor

@yuya-oc yuya-oc commented Nov 8, 2017

Before submitting, please confirm you've

Please provide the following information:

Summary
Ignore "gpu-process-crashed" event then output the log to console.

This PR changes throw new Error() to console.log. So the user will not see the event.
As investigated in #646, it doesn't affect the app.

Issue link
#646

Test Cases
a. Use the app. The app should not crash with the error of GPU process.
b. Kill the GPU process with Process Explorer.

Additional Notes
https://circleci.com/gh/yuya-oc/desktop/494#artifacts

@yuya-oc yuya-oc added the All Platforms null label Nov 8, 2017
@yuya-oc yuya-oc added this to the v3.8.0 milestone Nov 8, 2017
@yuya-oc
Copy link
Contributor Author

yuya-oc commented Nov 8, 2017

How to kill the GPU process:

  1. Use https://docs.microsoft.com/en-us/sysinternals/downloads/process-explorer instead of normal task manager to see processes.
  2. Search Mattermost.exe which has the parameter, --type=gpu-process.
  3. Kill the process from the context menu.

@yuya-oc
Copy link
Contributor Author

yuya-oc commented Nov 8, 2017

I tested the artifact of CircleCI. The app is still running even when the GPU process is killed.

@jasonblais
Copy link
Contributor

Thanks @yuya-oc! Tested and it works well 👍

@yuya-oc yuya-oc merged commit 5ccbeb0 into mattermost:master Nov 8, 2017
@yuya-oc yuya-oc deleted the ignore-gpu-process-crashed branch November 8, 2017 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants