Ignore "gpu-process-crashed" event then output the log to console #647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting, please confirm you've
npm run lint:js
for proper code formattingPlease provide the following information:
Summary
Ignore "gpu-process-crashed" event then output the log to console.
This PR changes
throw new Error()
toconsole.log
. So the user will not see the event.As investigated in #646, it doesn't affect the app.
Issue link
#646
Test Cases
a. Use the app. The app should not crash with the error of GPU process.
b. Kill the GPU process with Process Explorer.
Additional Notes
https://circleci.com/gh/yuya-oc/desktop/494#artifacts