Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Certificate Transparency verification #743

Merged

Conversation

yuya-oc
Copy link
Contributor

@yuya-oc yuya-oc commented Mar 26, 2018

Before submitting, please confirm you've

Please provide the following information:

Summary
Disable Certificate Transparency verification.

It seems that there is problem in Electron's Certificate Transparency verification.
electron/electron#11997

Some error cases reported at #742 would be solved by disabling the verification. This is issued against to release-4.0. And we need to know whether Electron v1.8.3 actually fixes the issue.
#742 (comment)

Issue link
#742

Test Cases

  • Case A: Certificate Transparency error

    1. Add the URL as a server which have the error appears.
    2. The error should not appear.
  • Case B: Actually invalid

    1. Add the URL as a server which is actually insecure. e.g. https://expired.sca1a.amazontrust.com/
    2. HTTPS error should appear.

Additional Notes
https://circleci.com/gh/yuya-oc/desktop/709#artifacts

@jasonblais
Copy link
Contributor

Thanks @yuya-oc! After this, we should be okay to just update the changelog, and cut the final for 4.0.1.

/cc @amyblais

@yuya-oc yuya-oc merged commit 1c116fa into mattermost:release-4.0 Mar 27, 2018
@yuya-oc yuya-oc deleted the disable-certificate-tranparency branch March 27, 2018 12:19
@jasonblais jasonblais added this to the v4.0.0 milestone Mar 27, 2018
@yuya-oc yuya-oc mentioned this pull request May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants