Disable Certificate Transparency verification #743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting, please confirm you've
npm run lint:js
for proper code formattingPlease provide the following information:
Summary
Disable Certificate Transparency verification.
It seems that there is problem in Electron's Certificate Transparency verification.
electron/electron#11997
Some error cases reported at #742 would be solved by disabling the verification. This is issued against to release-4.0. And we need to know whether Electron v1.8.3 actually fixes the issue.
#742 (comment)
Issue link
#742
Test Cases
Case A: Certificate Transparency error
Case B: Actually invalid
Additional Notes
https://circleci.com/gh/yuya-oc/desktop/709#artifacts