Clear webFrame cache at a certain interval #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattermost-webapp is SPA. So cache is not cleared due to no navigation. We needed to manually clear cache to free memory in long-term-use.
|
Thanks! I've been using the app today (on Mac) and posted in our performance channel for feedback from the team. |
|
@yuya-oc As discussed on pre-release, this PR should be ready to merge. |
|
@jasonblais Thanks for testing! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting, please confirm you've
npm run lint:jsfor proper code formattingPlease provide the following information:
Summary
Clear webFrame cache at a certain interval.
mattermost-webapp is SPA. So cache is not cleared due to no navigation by assuming this article.
http://seenaburns.com/debugging-electron-memory-usage/
We need to manually clear cache to free memory in long-term-use. Just for now, the interval is set to 1 hour.
Issue link
#710
Test Cases
Use an artifact for longer than the interval. After that, memory usage should not be highly increased.
For testing purpose, switching channels is a way to temporarily increase memory usage.
Additional Notes
https://circleci.com/gh/yuya-oc/desktop/712#artifacts