Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new loading animation #764

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

yuya-oc
Copy link
Contributor

@yuya-oc yuya-oc commented Apr 18, 2018

Before submitting, please confirm you've

Please provide the following information:

Summary
Apply new loading animation.

gif

Issue link
#748

Test Cases

  1. Open the desktop app.
  2. The animation should appear while loading the webapp.

Additional Notes
https://circleci.com/gh/yuya-oc/desktop/804#artifacts

Copy link
Member

@amyblais amyblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Windows, I'll check with Mike if he would be able to apply a continuous animation on the icon soon or if this will be part of other improvements on the icon for later.

@amyblais
Copy link
Member

@yuya-oc Mike just updated the animation, please see the ticket: https://mattermost.atlassian.net/browse/MM-8484

@yuya-oc yuya-oc force-pushed the new-loading-animation branch from 510e051 to 0c0cdb7 Compare April 21, 2018 15:50
@yuya-oc
Copy link
Contributor Author

yuya-oc commented Apr 21, 2018

@amyblais Thanks! Updated: https://circleci.com/gh/yuya-oc/desktop/809#artifacts

I could get fine result on my monitor, 150% of DPI scaling setting.

150%:
150percent

150% (without 2x image):
150percent_without_2x

@amyblais
Copy link
Member

Thank you @yuya-oc! I tested on Windows and it looks good - I think we are ready to merge this PR and get ready to cut RC-1.

@yuya-oc yuya-oc merged commit 12a7b7a into mattermost:master Apr 24, 2018
@yuya-oc yuya-oc deleted the new-loading-animation branch April 24, 2018 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants