Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes several typos #905

Merged
merged 2 commits into from
Dec 11, 2018
Merged

fixes several typos #905

merged 2 commits into from
Dec 11, 2018

Conversation

svelle
Copy link
Member

@svelle svelle commented Dec 2, 2018

Summary
This commit fixes several typos in comments and documentation as well as one typo in code for the electron webview spellchecker.

Copy link
Contributor

@yuya-oc yuya-oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated! Looks good to me.

@yuya-oc yuya-oc added this to the v4.3.0 milestone Dec 3, 2018
@jasonblais
Copy link
Contributor

Thank you!

@yuya-oc are the build errors something we should worry about?

@yuya-oc
Copy link
Contributor

yuya-oc commented Dec 10, 2018

@jasonblais No. Only 'set-spellcheker' is that, but it's correctly modified.

@svelle Would you solve conflicts? Then it would be ready to merge!

@svelle
Copy link
Member Author

svelle commented Dec 10, 2018

@yuya-oc sure I'll do that! I'll post here when I'm done.

@svelle
Copy link
Member Author

svelle commented Dec 10, 2018

Allright, resolved the conflicts. This should be good to go now :)

@yuya-oc
Copy link
Contributor

yuya-oc commented Dec 11, 2018

Thanks!

@yuya-oc yuya-oc merged commit 2aec40d into mattermost:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants