Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPO Template for controlling the upcoming Auto Updater #919

Merged
merged 4 commits into from
Feb 11, 2019
Merged

Add GPO Template for controlling the upcoming Auto Updater #919

merged 4 commits into from
Feb 11, 2019

Conversation

JtheBAB
Copy link
Contributor

@JtheBAB JtheBAB commented Jan 13, 2019

Before submitting, please confirm you've

Please provide the following information:

Summary
This GPO template allows Windows Domain Administrators to control the upcoming Auto Updater feature. Pull requested by @wget

Now as new branch and not the master branch of my fork.

Issue link
„Fixes“ #873

Copy link
Contributor

@yuya-oc yuya-oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late response.

Would you move files to resource/windows/gpo? scripts/ is a directory of helper scripts for developers. I think .adml and .admx should be distributed for admins (i.e. users), so they should be located under resource.

@yuya-oc
Copy link
Contributor

yuya-oc commented Jan 21, 2019

Just curious, should we have a document about .adml and .admx? (Because I'm merely not familiar with Group Policy.)

@JtheBAB
Copy link
Contributor Author

JtheBAB commented Jan 21, 2019

About the files --> see https://community.mattermost.com/core/pl/c34howw74frnpd6gkeoxg7eirw

I think it should be part of the docs.mattermost.com

@JtheBAB
Copy link
Contributor Author

JtheBAB commented Jan 21, 2019

I moved the files.

cc: @wget

@wget
Copy link
Collaborator

wget commented Jan 21, 2019

@JtheBAB great super!

Ping me when you have finished writing instructions for the documentation. That way I'll retest the whole process (I have Windows Server and Clients here). I'm unavailable until this Wednesday January 23th, so you have plenty of time :)

And btw, since you mentioned you were starting to play with GitHub pull requests, just a comment to make. PR always require a rebase. In a pull request, we only merge the modifications everyone has agreed upon. So first revisions (draft) are never included. So the first two commits are not needed and need a rebase :)
But you can leave it as it, because I want to check whether I have right to change YOUR branch since it appears they gave me (partial) commits rights. But I don't know whether this is applicable for this use case or if this only works via third party CI tools.

@wget
Copy link
Collaborator

wget commented Feb 1, 2019

Link to the documentation being written: mattermost/docs#2487

@esethna
Copy link
Contributor

esethna commented Feb 6, 2019

@yuya-oc @JtheBAB @wget are we blocked on anything to get this PR merged?

@yuya-oc what's involved in building the logic to support this?

@wget
Copy link
Collaborator

wget commented Feb 6, 2019

@esethna Actually, I wanted to port all the GPO features and have make a pull request with all of them in one shot instead, but that's okay, we can merge this one.

@JtheBAB
Copy link
Contributor Author

JtheBAB commented Feb 7, 2019

I am not blocked :)

@enahum enahum merged commit 6d3a368 into mattermost:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants