[MM-14740] Integrate GPO functionality #961
Conversation
| @@ -24,6 +24,7 @@ | |||
| "semver": "^5.5.0", | |||
| "simple-spellchecker": "^0.9.8", | |||
| "underscore": "^1.9.1", | |||
| "winreg": "^1.2.4", | |||
There was a problem hiding this comment.
can we file a ticket to have all of this dependencies to be exact?
There was a problem hiding this comment.
@enahum Why do you need them to be exact? The API shouldn't change for 1.x.x, so ^ appears to be correct IMHO.
https://stackoverflow.com/a/22345808/3514658
There was a problem hiding this comment.
Or maybe you want to have ~ instead?
There was a problem hiding this comment.
cause we use exact versions for dependencies everywhere and this one should not be the exception ;)
There was a problem hiding this comment.
@enahum Ok. Let's open a ticket for this asking to bumb dependencies as well. Because right, now according to npm there are still some deps we use for which we haven't applied updates. In the meantime, I merge this PR, because bumping dependencies will require another test session I don't want to do now since we have our open test release today :)
removed 1 package and audited 25559 packages in 55s
found 34 vulnerabilities (15 moderate, 19 high)
run `npm audit fix` to fix them, or `npm audit` for details
There was a problem hiding this comment.
Yeap, as I said this has to be another ticket which I already created https://mattermost.atlassian.net/browse/MM-15208
enahum
added
4: Reviews Complete
* integrate gpo functionality * support multiple windows registry ‘hives’ * correct some copy paste errors * registry config progress * tweaks
Before submitting, please confirm you've
npm run lint:jsfor proper code formattingPlease provide the following information:
Summary
This PR integrates GPO functionality by retrieving supported values set in the Windows registry and appropriately merging them with the app config.
NOTE: This functionality needs to be tested in a Windows environment configured with the appropriate GPO capabilities.