[MM-13267] Center badge count text and nomention dot #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also add padding and updated border radius to be a bit more consistent with badges in webapp
|
@jespino, apologies for basically wiping out your recent pull request for the mention dot 😛 |
|
@deanwhillier Can we also get screenshots of before and after? |
|
@deanwhillier hahaha no offense taken :) |
jespino
approved these changes
Jun 21, 2019
|
Absolutely, I added some after screenshots to the Jira ticket linked above. Before screenshots are already there. |
asaadmahmood
approved these changes
Jun 21, 2019
deanwhillier
added
4: Reviews Complete
JtheBAB
pushed a commit
to JtheBAB/desktop
that referenced
this pull request
Jan 17, 2020
- also add padding and updated border radius to be a bit more consistent with badges in webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting, please confirm you've
npm run lint:jsfor proper code formattingSummary
This PR adds some CSS tweaks to center mention badge counts and the nomention dot. Also adds some padding to better mimic the badges in the webapp.
Issue link
MM-13267
Additional Notes
It is possible that not all combinations of OS's and the Desktop app will work identically for this solution as we are not currently embedding the font we use in the app so the font used on a particular system may not position as well. I have tested on Mac OS 10.14.5 and Windows 10 Pro.