-
Notifications
You must be signed in to change notification settings - Fork 576
Conversation
contrib/swarm/docker-compose.yml
Outdated
- APP_HOST=mm_app | ||
# talk to the port within the overlay network | ||
# without (over)exposing ports | ||
- APP_PORT_NUMBER=80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some digging in the app container and it doesn't listen on port 8065 as stated in the current swarm file, but the port 80.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, don't know why it was like that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meant to be a single comment
contrib/swarm/docker-compose.yml
Outdated
deploy: | ||
restart_policy: | ||
condition: on-failure | ||
web: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also been able to make mattermost work without the web container provided here, and using traefik talking right to the app container instead. Could add an example if wanted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay to drop this container on the stack file as we discussed here. I use (and prefer) Traefik too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in that thread, this repo may keep flavors with the stack file, one with this web image, another with traefik.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can keep both that's a good things, but I don't know how to do that without duplicating a lot of configuration on both files ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, the config duplication is a problem, but I think maintaining both, the current one and the one with traefik will be enough support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, good for me to get both is you want to provide a Traefik example :)
Looks good to me, waiting for @xcompass approval too :) |
Btw i renamed the file |
I prefer to keep |
Nah, I just use |
@pichouk, just added the file with traefik |
LGTM, thanks @ulm0 :) |
* Better documentation for swarm file, avoid exposing ports for no reason * add swarm file using traefik
After reading the swarm file you guys offer, i saw it could be improved by "un-exposing" some ports for services that can talk to each other through the overlay network, and by adding some more documentation at the top of the file.