This repository has been archived by the owner on May 20, 2022. It is now read-only.
if all config was set in the config.json bypass the checks #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just test this in our helm chart and works like a charm 😄 |
pichouk
approved these changes
Sep 28, 2018
|
@pichouk thanks!! |
nickygerritsen
added a commit
to Lets-Talk-NL/mattermost-docker
that referenced
this pull request
Dec 21, 2018
* 'master' of https://github.com/mattermost/mattermost-docker: bump to 5.6.1 bump to version 5.6.0 Allow to properly shutdown web container bump to 5.5.1 renamed the vars to be better inline with the readme (mattermost#341) Bump to 5.5.0 downgrade alpine to 3.7 due xmlsec1 issues (mattermost#334) Improve app to db connection setup (mattermost#332) fix S3 wal-e support (mattermost#324) fix uuoc and typo (mattermost#333) fix permission in plugin folder (mattermost#331) Fix database HEALTHCHECK with correct user/db name (mattermost#330) Upgrade to 5.4.0 (mattermost#327) Fix typo (mattermost#323) Add warning about read_only (mattermost#321) Fix database healthcheck (mattermost#318) Remove DB check in the app/entrypoint (mattermost#316) if all config was set in the config.json bypass the checks (mattermost#315) add ability to build your own mm binary (mattermost#314)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the image more k8s friendly for our helm charts
if all the config was set in the config.json and we provide that dont need to check the DB.
also the check for the db in k8s is made by an init container.
this improve this image to work in k8s envs.
cc @jwilander