Skip to content
This repository has been archived by the owner on May 20, 2022. It is now read-only.

Cleanup of docker startup script for mattermost application #492

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Cleanup of docker startup script for mattermost application #492

merged 1 commit into from
Sep 18, 2020

Conversation

thePanz
Copy link
Contributor

@thePanz thePanz commented Aug 30, 2020

Summary

Cleanup of docker startup script for mattermost application

  • quote arguments to avoid globbing and word splitting
  • uniform format for if-then-else

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich

@jfrerich jfrerich added 2: Dev Review Requires review by a core committer and removed Lifecycle/1:stale labels Sep 10, 2020
@cpanato cpanato merged commit 66ab03e into mattermost:master Sep 18, 2020
@tohn
Copy link
Contributor

tohn commented Nov 4, 2020

Sorry, but I don't understand how this could be merged.
Neither was everything quoted nor are the if-then-else now in "uniform format" ...
I'll try to provide a PR soon.

@thePanz thePanz deleted the patch-1 branch November 4, 2020 17:32
@tohn tohn mentioned this pull request Nov 5, 2020
braunsonm added a commit to trecnoc/mattermost-docker that referenced this pull request Feb 8, 2021
* bump MM to 5.25.0

* Remove sudo: required as it is deprecated. (mattermost#485)

Co-authored-by: francois-d <dfrancis2.primus.ca>

* update MM to 5.25.1

* bump mm to 5.25.2

* add TLS 1.3 support to web container (mattermost#488)

* bump MM to 5.26.0

* bump MM to 5.26.1

* update MM to 5.27.0

* Quote arguments (mattermost#492)

* DOPS-215: Add MM_INSTALL_TYPE environment variable. (mattermost#497)

* bump based release

* Update SSL ciphers and TLS versions in nginx config file (mattermost#501)

* update MM to 5.29.0

* Consistency of app/* (mattermost#502)

* be consistent with the use of tabs

* tabs; shellcheck; consistency

* use tabs
* use shellcheck to fix non POSIX stuff
* be consistent with the use of quotes and if-then-else / for-do-done

* bump to use 5.29.1 release

* Enable easy configuration of encrypted PostgreSQL connections with new optional DB_SSLMODE (defaults to current value of "disable") following values allowed by PostgreSQL (mattermost#506)

* change to support environment variable configuration of SSL mode for PostgreSQL connections

* Update Dockerfile (mattermost#508)

* Updating shell scripts to adhear better to Bash style guides (mattermost#510)

* Updated Shell Script Format

Signed-off-by: Spencer <wf6DJd8a3xSSCZbn@protonmail.com>

* Update Dockerfile (mattermost#511)

Co-authored-by: Carlos Panato <ctadeu@gmail.com>
Co-authored-by: Francois-D <46973576+Francois-D@users.noreply.github.com>
Co-authored-by: nvjacobo <nvjacobo@users.noreply.github.com>
Co-authored-by: Emanuele Panzeri <thePanz@users.noreply.github.com>
Co-authored-by: Elisabeth Kulzer <elikul@elikul.de>
Co-authored-by: Simon Staszkiewicz <sstaszkiewicz@copperleaf.com>
Co-authored-by: Yannic Haupenthal <tohn@users.noreply.github.com>
Co-authored-by: Dave Thompson <64275573+3leapsdet@users.noreply.github.com>
Co-authored-by: Amy Blais <amy_blais@hotmail.com>
Co-authored-by: wf6DJd8a3xSSCZbn <50090275+wf6DJd8a3xSSCZbn@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants