Check for ExternalDBSettings while starting a load test #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of ExternalDB there will be no cluster identifier from a Terraform deployment.
agarciamontoro
requested changes
Feb 4, 2025
|
LMK how it looks now. I am distinguishing the presence of a |
agarciamontoro
approved these changes
Feb 5, 2025
Comment on lines
+99
to
+102
| // If an external non-AWS DB is used. | ||
| if t.config.ExternalDBSettings.DataSource != "" && t.config.ExternalDBSettings.ClusterIdentifier == "" { | ||
| return "available", nil | ||
| } |
There was a problem hiding this comment.
Not for this PR, but: is there a way we can test the connection to the datasource here? It would need to be from one of the app nodes, but maybe it's worth doing it to make sure all is working as expected.
There was a problem hiding this comment.
At which phase do you want to test it? This DBStatus method is purely geared towards AWS instances so that we can turn them off to save money. I think we could test this in the deployment phase, but it should automatically fail if the servers won't start.
Co-authored-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>
cpoile
approved these changes
Feb 7, 2025
agnivade
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of ExternalDB there will be no cluster identifier
from a Terraform deployment.