-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update marketplace entries for ReactDOM updates #317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@mickmister I see an issue here where 3 of the 6 plugin will not start.
Furthermore - This occurs when I manually download the plugin from the releases page and upload it. Can you please advise on next steps? Edit Forgot to mention - Jitsi, ToDO and Custom Attributes seem unaffected. |
@DHaussermann This PR is ready for review. Please see these steps for testing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed.
- Tested fresh install path for all patched plugins
- Tested upgrade path for all patched plugins
- Ensured all plugins can be enabled on Cloud servers
- Sanity checked all patched plugins are running and responsive
- Checked plugins to ensure react select specifically is functional (GitHub, Jira, Custom Attributes)
No issues found.
LGTM!
Huge thanks @mickmister for the effort on this and working around the build pipeline issues that were causing blocks.
Summary
This PR updates the marketplace entries of specific plugins that are affected by the React 17 upgrade. More context here mattermost/mattermost-plugin-starter-template#169
Plugins updated:
mattermost-plugin-confluence
mattermost-plugin-custom-attributes
mattermost-plugin-github
mattermost-plugin-gitlab
mattermost-plugin-jira
mattermost-plugin-jitsi
mattermost-plugin-todo
Ticket Link
https://mattermost.atlassian.net/browse/MM-47046