Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update marketplace entries for ReactDOM updates #317

Merged
merged 6 commits into from
Nov 30, 2022

Conversation

mickmister
Copy link
Contributor

@mickmister mickmister commented Nov 8, 2022

Summary

This PR updates the marketplace entries of specific plugins that are affected by the React 17 upgrade. More context here mattermost/mattermost-plugin-starter-template#169

Plugins updated:

  • mattermost-plugin-confluence
  • mattermost-plugin-custom-attributes
  • mattermost-plugin-github
  • mattermost-plugin-gitlab
  • mattermost-plugin-jira
  • mattermost-plugin-jitsi
  • mattermost-plugin-todo

Ticket Link

https://mattermost.atlassian.net/browse/MM-47046

@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Nov 8, 2022
hanzei
hanzei previously approved these changes Nov 10, 2022
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Nov 10, 2022
@DHaussermann
Copy link

DHaussermann commented Nov 16, 2022

@mickmister I see an issue here where 3 of the 6 plugin will not start.
image
Unclear if this could be a marketplace issue or with the binary published as the release. logs suggest the correct binary was downloaded from the marketplace...

{"timestamp":"2022-11-16 19:43:20.360 Z","level":"error","msg":"plugin process exited","caller":"plugin/hclog_adapter.go:79","plugin_id":"jira","wrapped_extras":"pathplugins/jira/server/dist/plugin-linux-amd64pid134errorexit status 1"}
{"timestamp":"2022-11-16 19:43:20.360 Z","level":"error","msg":"Unable to activate plugin","caller":"app/plugin.go:183","plugin_id":"jira","error":"unable to start plugin: jira: Unrecognized remote plugin message: \n\nThis usually means that the plugin is either invalid or simply\nneeds to be recompiled to support the latest protocol."}

Furthermore - This occurs when I manually download the plugin from the releases page and upload it.

Can you please advise on next steps?

Edit Forgot to mention - Jitsi, ToDO and Custom Attributes seem unaffected.

@mickmister
Copy link
Contributor Author

@DHaussermann This PR is ready for review. Please see these steps for testing:


  • Create a cloud server with the following command:

/cloud create react-dom-marketplace-test --version master --image mattermost/mm-ee-test --env MM_LOGSETTINGS_FILELEVEL=DEBUG

  • Notice plugin version numbers in marketplace:

    • confluence - v1.2.0
    • custom-attributes - v1.3.0
    • github - v2.1.2
    • gitlab - v1.5.0
    • jira - v3.2.0
    • jitsi - v2.0.0
    • todo - v0.6.0
  • Install the custom attributes plugin

  • Enable plugin and go to the custom attributes plugin settings

  • Attempt to add a new attribute, including typing in the teamName select box

  • Notice the webapp crashes due to ReactDOM issue


  • Run this marketplace PR locally, and expose with ngrok

  • Set the MM server's marketplace URL to this ngrok URL

  • Notice the change in marketplace version numbers:

    • confluence - v1.3.0
    • custom-attributes - v1.3.1
    • github - v2.1.4
    • gitlab - v1.5.2
    • jira - v3.2.2
    • jitsi - v2.0.1
    • todo - v0.6.1
  • Upgrade custom attributes plugin

  • Attempt to add a new attribute, including typing in the teamName select box

  • Notice that the plugin functions correctly, and the webapp does not crash

  • Upgrade other plugins, and perform exploratory testing, particularly where select boxes are used

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed.

  • Tested fresh install path for all patched plugins
  • Tested upgrade path for all patched plugins
  • Ensured all plugins can be enabled on Cloud servers
  • Sanity checked all patched plugins are running and responsive
  • Checked plugins to ensure react select specifically is functional (GitHub, Jira, Custom Attributes)

No issues found.

LGTM!

Huge thanks @mickmister for the effort on this and working around the build pipeline issues that were causing blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants