Restore out of channel and some cleanup #8050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkox
added
2: Dev Review
harshilsharma63
approved these changes
Jul 2, 2024
|
@rahimrahman Friendly reminder on this |
enahum
approved these changes
Jul 8, 2024
yasserfaraazkhan
approved these changes
Jul 9, 2024
larkox
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On 105073c the "Out of Channel" section was removed from the user autocomplete per the feature specifications, but after the change was made, we realized we still nee the "Out of Channel" section.
This PR reverts back the changes related to removing the out of channel section, and do a bit of cleanup moving the different util functions, types and constants to their own files for better readability of the component file.
Ticket Link
Fix https://mattermost.atlassian.net/browse/MM-58508
Release Note