Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more utils unit test coverage #8068

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Add more utils unit test coverage #8068

merged 1 commit into from
Jul 11, 2024

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Jul 8, 2024 •
edited
Loading

Summary

Increase unit test coverage for utils/channels utils/deep_link utils/document utils/draft and utils/emoji/helpers

image

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Release Note

NONE

@enahum enahum added the 2: Dev Review Requires review by a core commiter label Jul 8, 2024
@enahum enahum requested review from larkox and jwilander July 8, 2024 23:11
@enahum enahum added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Jul 11, 2024
@enahum enahum merged commit 9bdb5c1 into main Jul 11, 2024
24 checks passed
@enahum enahum deleted the utils-test branch July 11, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwilander jwilander jwilander approved these changes

@larkox larkox larkox approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enahum @larkox @jwilander @mm-cloud-bot