Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-53016] Pass timeout to outgoing request to MM server #476

Merged
merged 7 commits into from
Aug 28, 2023

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Aug 8, 2023

Summary

Since v8 model.Client accepts a context.Context(). This PR makes use of the new functionality by passing down the request context, which ensures the request gets cancelled if it times out.

The PR also includes the telemetry fix from mattermost/mattermost-plugin-jira#930.

Ticket Link

https://mattermost.atlassian.net/browse/MM-53016

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Aug 8, 2023
@hanzei hanzei added this to the v1.3.0 milestone Aug 8, 2023
@hanzei hanzei requested a review from mickmister August 8, 2023 09:29
@hanzei hanzei changed the title Pass timeout to outgoing request to MM server [MM-53016] Pass timeout to outgoing request to MM server Aug 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Patch coverage: 6.66% and project coverage change: -0.02% ⚠️

Comparison is base (b235e01) 20.13% compared to head (afac1fe) 20.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
- Coverage   20.13%   20.12%   -0.02%     
==========================================
  Files          80       80              
  Lines        6605     6609       +4     
==========================================
  Hits         1330     1330              
- Misses       5143     5147       +4     
  Partials      132      132              
Files Changed Coverage Δ
apps/app.go 0.00% <ø> (ø)
apps/context.go 36.36% <ø> (ø)
apps/expand.go 15.27% <ø> (ø)
server/config/config.go 34.61% <ø> (ø)
server/config/mattermost_config_service.go 0.00% <ø> (ø)
server/config/service.go 0.00% <ø> (ø)
server/config/test_service.go 0.00% <ø> (ø)
server/proxy/bindings.go 32.00% <ø> (ø)
server/proxy/expand_getter.go 0.00% <0.00%> (ø)
server/proxy/install.go 0.00% <ø> (ø)
... and 12 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanzei hanzei merged commit 89a1e4c into master Aug 28, 2023
7 checks passed
@hanzei hanzei deleted the MM-53016_timeout branch August 28, 2023 09:06
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request Docs/Not Needed Does not require documentation and removed 2: Dev Review Requires review by a core committer labels Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Docs/Not Needed Does not require documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants