Remove type from call and consider type on path for helloapp #99
Conversation
| @@ -19,9 +20,6 @@ func (h *helloapp) GetBindings(w http.ResponseWriter, req *http.Request, claims | |||
| } | |||
|
|
|||
| func (h *helloapp) Install(w http.ResponseWriter, req *http.Request, claims *api.JWTClaims, c *apps.CallRequest) (int, error) { | |||
| if c.Type != apps.CallTypeSubmit { | |||
There was a problem hiding this comment.
do we have to remove this? Has anything changed?
There was a problem hiding this comment.
Since calls don't have type anymore, there is no need to check the type here. Since install is called from the server, it does not go under a subpath (e.g. /install/submit) but directly to the endpoint.
Does it make sense? Or should all calls (including bindings and install) go to the subpath?
@levb thoughts?
|
/update-branch |
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=======================================
Coverage 24.48% 24.48%
=======================================
Files 27 27
Lines 976 976
=======================================
Hits 239 239
Misses 721 721
Partials 16 16 Continue to review full report at Codecov.
|
Summary
Remove type from call and consider type on path for helloapp
Ticket Link
https://mattermost.atlassian.net/browse/MM-33178
Related Pull Requests
Redux: mattermost/mattermost-redux#1406
Webapp: mattermost/mattermost-webapp#7679
Mobile: mattermost/mattermost-mobile#5221