Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop logging errors for api error responses #8

Merged
merged 2 commits into from
Jul 15, 2024
Merged

stop logging errors for api error responses #8

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94b3083
stop logging errors for api error responses
lieut-data Jul 4, 2024
a021d7b
Update server/api/api.go
lieut-data Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions server/api/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ func (a *API) userIsGuest(userID string) (bool, error) {
// Response helpers

func (a *API) errorResponse(w http.ResponseWriter, r *http.Request, err error) {
a.logger.Error(err.Error())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This explains the double log entries for each error

errorResponse := model.ErrorResponse{Error: err.Error()}

switch {
Expand All @@ -195,15 +194,16 @@ func (a *API) errorResponse(w http.ResponseWriter, r *http.Request, err error) {
case model.IsErrNotImplemented(err):
errorResponse.ErrorCode = http.StatusNotImplemented
default:
a.logger.Error("API ERROR",
mlog.Int("code", http.StatusInternalServerError),
mlog.Err(err),
mlog.String("api", r.URL.Path),
)
errorResponse.Error = "internal server error"
errorResponse.ErrorCode = http.StatusInternalServerError
}

a.logger.Warn("api error response",
mlog.Int("code", http.StatusInternalServerError),
lieut-data marked this conversation as resolved.
Show resolved Hide resolved
mlog.Err(err),
mlog.String("api", r.URL.Path),
)

setResponseHeader(w, "Content-Type", "application/json")
data, err := json.Marshal(errorResponse)
if err != nil {
Expand Down
Loading