[MM-55503] Add support for new DesktopAPI

[streamer45]

Summary

PR adds support for the new DesktopAPI. It deprecates the previous logic which is left for backwards compatibility (new plugin with older Desktop app).

@cpoile Will need some help to verify nothing got broken calls ringing wise. I did some manual smoke testing but a second look would be good.

Related PR

mattermost/desktop#2937

Ticket Link

https://mattermost.atlassian.net/browse/MM-55503

[streamer45]

Need to update this once we merge the desktop side PR.

[streamer45]

Need to update this once we merge the desktop side PR.

[cpoile]

Yep 👍

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2df6784) 0.00% compared to head (ba8afe5) 9.37%.
Report is 8 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##           main    #602      +/-   ##
=======================================
+ Coverage      0   9.37%   +9.37%     
=======================================
  Files         0      26      +26     
  Lines         0    5303    +5303     
=======================================
+ Hits          0     497     +497     
- Misses        0    4754    +4754     
- Partials      0      52      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[devinbinnie]

You probably don't need this anymore, it's unfortunately still there because of the version field, which has been replaced by getAppInfo under the desktopAPI

[cpoile]

Looks great, the new API is much nicer. Too bad we have so many ifs and paths now, but can't be helped.
Edit: I tested using the MM-55503 branch of desktop and the calls notifications are working.

[devinbinnie]

Looks great, the new API is much nicer. Too bad we have so many ifs and paths now, but can't be helped.

That's just for backwards compatibility. That will go away in time :)

[streamer45]

@DHaussermann as mentioned in our 1-1, looking for some smoke testing on this, covering the following functionalities:

• Screen sharing
  • Mostly making sure the screen/window selection works as expected.
• Joining/leaving calls
  • Clicking buttons in either widget or pop out window.
• Clicking on channel link in call widget
  • Making sure it focuses the app and switches to the channel
• Calls errors showing on the Desktop app. Once in a call you can trigger fake errors from the JS console e.g.:
  • window.callsClient.disconnect(new Error('some error'));
• Calls ringing widget notifications

Also looking to cover the following desktop/plugin version combinations:

• Backwards compatibility:
  • New desktop ([MM-55503] Update Calls Desktop API desktop#2937), old plugin (without this PR essentially)
  • Old desktop, new plugin
• New desktop, new plugin

Please ping me if you need any help with setting up things or more clarity on the above.

[streamer45]

@DHaussermann Heads up that the Desktop side PR has been merged so I updated the dependency on this side. This means you can now use desktop master branch (or a build of it) to test the new desktop version.

[DHaussermann]

Tested and passed
I deployed the Calls plugin from this PR branch to a test server and tested from an advance v5.7.0 desktop release which contained mattermost/desktop#2937

• Used the calls plugin and sanity checked actions and basic functions mute emoji etc..
• Join / leave a call
• Start / end a call
• Share a screen and stop
• Performed all action from both the collapse modal as well as the expanded view
• Downgraded desktop client to v5.6.0 and repeated all exploratory tests to guard agains regression risk
• No issues or changes in behavior found

LGTM!

Sorry for the delay on this. @cpoile please merge when you have a chance.