Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make our load-test client speak 🗣️ 🪄 #614

Merged
merged 11 commits into from
Apr 10, 2024
Merged

Make our load-test client speak 🗣️ 🪄 #614

merged 11 commits into from
Apr 10, 2024

Conversation

streamer45
Copy link
Collaborator

@streamer45 streamer45 commented Jan 12, 2024

Summary

PR adds a couple of functionalities to our load-test client:

  • A new -speech-file flag to pass any valid audio Opus encoded file. I am including two generated speech samples with their text source.
    • This could be useful to measure transcription quality and performance of well known samples.
  • A way to generate speech from text on the fly and essentially script conversations. See lt/cmd/speech/main.go.
    • This allows for a more flexible way to test realistic conversations between multiple users.

Had to restructure things a bit to make this work so updating the docs as well.

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Jan 12, 2024
@streamer45 streamer45 self-assigned this Jan 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9477c5a) 9.36% compared to head (1e7d3bf) 9.36%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #614   +/-   ##
=====================================
  Coverage   9.36%   9.36%           
=====================================
  Files         26      26           
  Lines       5308    5308           
=====================================
  Hits         497     497           
  Misses      4759    4759           
  Partials      52      52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@streamer45
Copy link
Collaborator Author

Made ./lt a separate Golang module because it actually didn't make sense to share dependencies with the plugin, even more so now that we have some CGO stuff in there (opus).

Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because it works and I've made enough changes/additions on my side that to make any here would cause some bad conflicts.
Thank you again for this, truly helpful for the live captions testing.

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 25, 2024
@streamer45
Copy link
Collaborator Author

@cpoile It's the flaky one again, will merge.

@streamer45 streamer45 merged commit cc0336c into main Apr 10, 2024
6 of 7 checks passed
@streamer45 streamer45 deleted the lt-speech branch April 10, 2024 23:14
@cpoile cpoile restored the lt-speech branch April 10, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants