Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm link for @calls/common #625

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Fix npm link for @calls/common #625

merged 1 commit into from
Jan 19, 2024

Conversation

streamer45
Copy link
Collaborator

Summary

Working process is as follows:

  1. Run npm link in your local calls-common repo directory.
  2. Run npm link @calls/common in both mattermost-plugins-calls/webapp and mattermost-plugin-calls/standalone.
  3. Build plugin as normal

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Jan 19, 2024
@streamer45 streamer45 self-assigned this Jan 19, 2024
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭 🙇

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 19, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (738ae2b) 9.33% compared to head (8e47d10) 9.33%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #625   +/-   ##
=====================================
  Coverage   9.33%   9.33%           
=====================================
  Files         26      26           
  Lines       5293    5293           
=====================================
  Hits         494     494           
  Misses      4747    4747           
  Partials      52      52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@streamer45 streamer45 merged commit 448baef into main Jan 19, 2024
6 checks passed
@streamer45 streamer45 deleted the fix-npm-link branch January 19, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants