Migrate to styled components v6 #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpoile That e2e test is starting to fail a bit too often. Could you have a look when you get a chance? May be a simple timeout issue. |
streamer45
added
the
Do Not Merge/Awaiting PR
cpoile
approved these changes
Apr 9, 2024
|
I've made a ticket for the flaky tests: https://mattermost.atlassian.net/browse/MM-57753 They don't seem to just be timeouts; they're failing in different ways each time. So I suspect something is not working reliably on the client during the tests. |
* UX improvements to call card * Proper wrapping * Language update * Fixes after icon update * Update snapshots * Update e2e test * Implement narrow layout * Update e2e snapshots * Fix row gap * Fix divider's border
streamer45
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR migrates styled components from v5 to v6 to support container queries (to properly address #675).
It was a bit more painful than ideal and some things just broke without warning (e.g. button hover states). Hopefully I caught them all but there totally could be something more I missed.