Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-57323] Update node/npm to match webapp #700

Merged
merged 7 commits into from
Apr 22, 2024
Merged

[MM-57323] Update node/npm to match webapp #700

merged 7 commits into from
Apr 22, 2024

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Apr 17, 2024 •
edited
Loading

Summary

  • Update node/npm
  • Update webapp to March 18 (when the update was done on that side)
  • Update some npm packages to keep pace with mattermost
  • Fix webpack errors (yay)
  • Clean up types

Ticket Link

@cpoile cpoile requested a review from streamer45 April 17, 2024 20:17
@cpoile cpoile added the 2: Dev Review Requires review by a core committer label Apr 17, 2024
@streamer45
Copy link
Collaborator

You always find ways to cheat stats in your favor 😒

@cpoile
Copy link
Member Author

cpoile commented Apr 17, 2024

@streamer45 See, stats change our behaviour and our reactions.
I vote we dump stats altogether.

@streamer45
Copy link
Collaborator

Your performance is defined by those stats so better keep them if you want to be around for longer :p

@streamer45 streamer45 added this to the v0.27.0 / MM 9.9 milestone Apr 17, 2024
streamer45
streamer45 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, apologies for the delay on this.

webapp/src/actions.ts
@@ -369,7 +372,7 @@ export function incomingCallOnChannel(channelID: string, callID: string, callerI
await dispatch(getProfilesByIdsAction([callerID]));
}

await dispatch({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So dispatching is always synchronous or there's more to it?

Copy link
Member Author

@cpoile cpoile Apr 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, dispatching is async, it's just that putting await dispatch at the return is useless/redundant (since an async function returns a promise immediately, so awaiting it does nothing).

webapp/webpack.config.js
@@ -17,7 +17,7 @@ if (NPM_TARGET === 'debug' || NPM_TARGET === 'debug:watch') {

const plugins = [
new webpack.ProvidePlugin({
process: 'process/browser',
process: 'process/browser.js',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this wasn't too painful to figure out 😬

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was touch and go there for a bit (my sanity)

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Apr 22, 2024
@streamer45
Copy link
Collaborator

@cpoile One thing I noticed is that my local env is generating a different package-lock.json when installing this.

github.com/mattermost/mattermost-plugin-calls » node -v
v20.11.1
github.com/mattermost/mattermost-plugin-calls » npm -v
10.2.4

@cpoile
Copy link
Member Author

cpoile commented Apr 22, 2024 •
edited
Loading

@streamer45 Try now -- I might have been running into an issue where I was running npm i with the old webapp, then the new webapp gets installed, and then I should have run it again (since there's new code now for npm to run against). I did that and found it was then failing on typescript incompatibilities. Upgraded that, and then react-intl is showing some type errors... But it's still working (and we're using it exactly as the docs show it -- and even those docs examples throw this new error), so looks like the typings are broken at the moment (or there's an interaction with the typescript version). Anyway, I ignored them for now because I couldn't find a fix after working on it for way too long.

streamer45
streamer45 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's get it merged because all this moving from one version to another locally is driving me nuts :p

@cpoile cpoile merged commit 3f18a0c into main Apr 22, 2024
19 checks passed
@cpoile cpoile deleted the MM-57323-update-node-npm branch April 22, 2024 23:38
@streamer45 streamer45 mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamer45 streamer45 streamer45 approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v0.27.0 / MM 9.9
Development

Successfully merging this pull request may close these issues.
2 participants
@cpoile @streamer45