Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-58016] Some eslint simplifications #712

Merged
merged 1 commit into from
Apr 25, 2024
Merged

[MM-58016] Some eslint simplifications #712

merged 1 commit into from
Apr 25, 2024

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Apr 24, 2024 •
edited
Loading

Summary

  • This will help a little, but we still have to keep the main eslint packages up to date manually. When we update mattermost-webapp's hash we'll have to also update our eslint versions to match.
  • I'm happy standalone can use the webapp's eslintrc. :)

Ticket Link

@cpoile cpoile requested a review from streamer45 April 24, 2024 19:32
@cpoile cpoile added the 2: Dev Review Requires review by a core committer label Apr 24, 2024
streamer45
streamer45 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Apr 24, 2024
@streamer45 streamer45 added this to the v0.27.0 / MM 9.9 milestone Apr 24, 2024
@cpoile cpoile merged commit 1e9b03c into main Apr 25, 2024
19 checks passed
@cpoile cpoile deleted the MM-58016-eslint branch April 25, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamer45 streamer45 streamer45 approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v0.27.0 / MM 9.9
Development

Successfully merging this pull request may close these issues.
2 participants
@cpoile @streamer45