[MM-58085] Improve calls load balancing logic #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
streamer45
commented
May 2, 2024
Comment on lines
+270
to
+273
| // Fallback to random choice if we couldn't get system info. | ||
| if hostWithMinLoad == nil { | ||
| hostWithMinLoad = hostsAvailable[rand.Intn(len(hostsAvailable))] | ||
| } |
There was a problem hiding this comment.
This and the continue in case of error above are to make the change backward compatible in which case we'd be using a randomized approach.
streamer45
added
3: Reviews Complete
|
@cpoile Asking for re-review since I slightly changed the logic after I noticed that the 1 minute average wasn't as reactive as I would have liked. We are now using a 2-second instant load (see https://github.com/mattermost/rtcd/tree/MM-54335-improvements). |
streamer45
added
2: Dev Review
cpoile
added
3: Reviews Complete
streamer45
removed
the
Do Not Merge/Awaiting PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR implements a (hopefully) more efficient load-balancing logic for calls. Up until now, we'd be using a simple round-robin approach which can work well for lots of smaller calls but it can be quite inefficient in case of larger calls.
The proposed changes will fetch actual system load (CPU) info from the rtcd instances and select the host with the lower load.
The rationale here is that we know CPU to be the main performance bottleneck. Exposing this information avoids having to calculate the load in more complex ways such as figuring out how many connections and tracks (and their type) we are sending at any given time.
Ticket Link
https://mattermost.atlassian.net/browse/MM-58085