Bump rtcd to latest v0.15.0 #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoile
approved these changes
May 8, 2024
streamer45
commented
May 8, 2024
| @@ -182,7 +182,7 @@ func (p *Plugin) OnActivate() error { | |||
| rtcServerConfig.TURNConfig.StaticAuthSecret = cfg.TURNStaticAuthSecret | |||
| } | |||
| if cfg.ICEHostPortOverride != nil { | |||
| rtcServerConfig.ICEHostPortOverride = *cfg.ICEHostPortOverride | |||
| rtcServerConfig.ICEHostPortOverride = rtc.ICEHostPortOverride(fmt.Sprintf("%d", *cfg.ICEHostPortOverride)) | |||
There was a problem hiding this comment.
I think it's reasonable to keep supporting the basic syntax (single port) only from this side. We can always review later if needed but for anything advanced I'd say they should be using rtcd.
streamer45
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumping
rtcdto the latest release.