Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry picks for 0.28.2 #793

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Cherry picks for 0.28.2 #793

merged 2 commits into from
Jun 21, 2024

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Jun 21, 2024

* fix broken notifications test

* one more

* ci e2e isn't behaving the way local e2e is behaving...

* ci e2e isn't behaving the way local e2e is behaving...

* reload and wait after patching

* timeouts are not necessary

* remove redundant reload; move one reload earlier for consistency

(cherry picked from commit 2df639b)
@cpoile cpoile added the 2: Dev Review Requires review by a core committer label Jun 21, 2024
@cpoile cpoile requested a review from streamer45 June 21, 2024 11:55
@cpoile cpoile changed the base branch from main to release-0.28 June 21, 2024 11:55
@streamer45
Copy link
Collaborator

@cpoile Why to main?

@streamer45
Copy link
Collaborator

Okay :P

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jun 21, 2024
@streamer45 streamer45 added this to the v0.28.2 milestone Jun 21, 2024
@cpoile cpoile merged commit 9e5cae2 into release-0.28 Jun 21, 2024
20 checks passed
@cpoile cpoile deleted the cherry-picks-for-0.28.2 branch June 21, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants