Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls v1 prep #845

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Calls v1 prep #845

merged 3 commits into from
Aug 14, 2024

Conversation

streamer45
Copy link
Collaborator

Summary

We are making MM v10 a requirement for running Calls v1 since it makes it more explicit we are introducing breaking changes (namely Calls being available only in DMs for unlicensed servers).

Also bumping some Calls dependencies in the process as we are wrapping up the release.

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Aug 14, 2024
@streamer45 streamer45 added this to the v1.0.0 🚀 / MM 10.0 milestone Aug 14, 2024
@streamer45 streamer45 self-assigned this Aug 14, 2024
Copy link
Member

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isacikgoz isacikgoz added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Aug 14, 2024
@streamer45 streamer45 merged commit 67a9131 into main Aug 14, 2024
19 checks passed
@streamer45 streamer45 deleted the v1-prep branch August 14, 2024 13:51
@Tampa
Copy link

Tampa commented Sep 24, 2024

And here we go, the downfall has begun. No calls in public channels anymore, wtf is this shit. Excuse my french, but that's killing the one thing that made the call function useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants