[MM-61166] Ensure full validation of Calls post props #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
cpoile
approved these changes
Oct 23, 2024
webapp/src/utils.ts
Outdated
Comment on lines
587
to
588
| recordings: isValidObject(post.props?.recordings) ? post.props.recordings : {}, | ||
| transcriptions: isValidObject(post.props?.transcriptions) ? post.props.transcriptions : {}, |
There was a problem hiding this comment.
Do we need to validate that the recordings and transcriptions objects are valid?
There was a problem hiding this comment.
@cpoile They are not used right now, but we should. Let me tackle that as part of https://mattermost.atlassian.net/browse/MM-61228
esarafianou
approved these changes
Oct 24, 2024
* Surface transcriptions in call post * Add proper job metadata validation
streamer45
added
3: Reviews Complete
streamer45
added a commit
that referenced
this pull request
Oct 25, 2024
* Ensure full validation of Calls post props * [MM-61228] Surface transcriptions in call post (#886) * Surface transcriptions in call post * Add proper job metadata validation
streamer45
added a commit
that referenced
this pull request
Oct 25, 2024
* Ensure full validation of Calls post props * [MM-61228] Surface transcriptions in call post (#886) * Surface transcriptions in call post * Add proper job metadata validation
streamer45
added a commit
that referenced
this pull request
Oct 25, 2024
* [MM-61166] Ensure full validation of Calls post props (#885) * Ensure full validation of Calls post props * [MM-61228] Surface transcriptions in call post (#886) * Surface transcriptions in call post * Add proper job metadata validation * [MM-61298] Fix e2e pipeline (#888) * Fix e2e pipeline * We don't need ES * Fix docker login step (#881) * Fix docker login step * Update .github/workflows/e2e.yml Co-authored-by: Mario Vitale <mvitale1989@hotmail.com> --------- Co-authored-by: Mario Vitale <mvitale1989@hotmail.com> * Fix e2e pipeline flakyness (#867) --------- Co-authored-by: Mario Vitale <mvitale1989@hotmail.com>
streamer45
added a commit
that referenced
this pull request
Oct 25, 2024
* [MM-61298] Fix e2e pipeline (#888) * Fix e2e pipeline * We don't need ES * Fix docker login step (#881) * Fix docker login step * Update .github/workflows/e2e.yml Co-authored-by: Mario Vitale <mvitale1989@hotmail.com> --------- Co-authored-by: Mario Vitale <mvitale1989@hotmail.com> * [MM-61166] Ensure full validation of Calls post props (#885) * Ensure full validation of Calls post props * [MM-61228] Surface transcriptions in call post (#886) * Surface transcriptions in call post * Add proper job metadata validation --------- Co-authored-by: Mario Vitale <mvitale1989@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since props cannot be trusted (i.e., users can alter them at any time on their posts), we must take extra care to ensure that the type of them is what we expect it to be.
Ticket Link
https://mattermost.atlassian.net/browse/MM-61166