[MM-61233] Verify no error is shown when running slash commands #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoile
approved these changes
Oct 24, 2024
| @@ -77,6 +77,7 @@ test.describe('start new call', () => { | |||
| await page.locator('#post_textbox').fill('/call leave'); | |||
| await page.getByTestId('SendMessageButton').click(); | |||
| await expect(page.locator('#calls-widget')).toBeHidden(); | |||
| await expect(page.locator('#postCreateFooter .has-error')).toBeHidden(); | |||
There was a problem hiding this comment.
nit: or not be visible? (because it's not really hidden...) 🤷
There was a problem hiding this comment.
@cpoile Playwright semantic is the same though. It's just a bit more compact to use toBeHidden() vs not.toBeVisible().
Otherwise we'd have to use something like toBeAttached which specifically checks for presence in the DOM rather than visibility.
streamer45
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding some extra checks so that we could have caught this way sooner.
Ticket Link
https://mattermost.atlassian.net/browse/MM-61233