[MM-61224] Add tooltip to screen source names #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoile
approved these changes
Oct 29, 2024
| @@ -133,7 +134,17 @@ export default class ScreenSourceModal extends React.PureComponent<Props, State> | |||
| src={source.thumbnailURL} | |||
| /> | |||
| </div> | |||
| <span style={this.style.sourceLabel as CSSProperties}>{source.name}</span> | |||
|
|
|||
| <OverlayTrigger | |||
There was a problem hiding this comment.
If I'm not mistaken, I think new code should use the new floating-ui framework? (There was a PR by Daniel adding a new tooltip we should use, I think...)
I'll leave it up to you though, considering this is just a small addition.
There was a problem hiding this comment.
I think these should be migrated to WithTooltip (https://mattermost.atlassian.net/browse/MM-57219). Something for next Fixathon I suppose.
streamer45
added
3: Reviews Complete
streamer45
added a commit
that referenced
this pull request
Nov 11, 2024
streamer45
added a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We implement a tooltip so that longer source names that it's easy to display the full name in case it gets truncated.
/cc @matthewbirtch
Screenshot
Ticket Link
https://mattermost.atlassian.net/browse/MM-61224