[CLD-8682] Support for 24h deletion pending window in test env #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
the
release-note-none
stylianosrigas
approved these changes
Dec 16, 2024
nickmisasi
added
the
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adjusts how informative the error is when attempting to create an installation with a name that is already reserved. The plugin already checks for existence, so that error was adjusted, but I've also added a check for a 409 return from the Provisioner if that initial lookup fails for whatever reason.
This PR also changes the "installation deleted" message to be webhook-driven - it will compare actor_id from the incoming webhook to the client ID the plugin has been assigned for authentication - if they're the same, it knows the action was completed by the plugin, so the message is adjusted (ie, deleted manually). If not, it knows that the installation was deleted via an automated process.
Ticket Link
https://mattermost.atlassian.net/browse/CLD-8628
Release Note