Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter errors #154

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Fix linter errors #154

merged 2 commits into from
Oct 14, 2022

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Oct 4, 2022

Summary

Fix linter errors caused by golangci-lint update

Ticket Link

None

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Oct 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2022

Codecov Report

Base: 17.68% // Head: 17.68% // No change to project coverage 👍

Coverage data is based on head (ddb694c) compared to base (6249a5d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   17.68%   17.68%           
=======================================
  Files          15       15           
  Lines        1414     1414           
=======================================
  Hits          250      250           
  Misses       1123     1123           
  Partials       41       41           
Impacted Files Coverage Δ
server/configuration.go 51.61% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hanzei hanzei requested a review from mickmister October 4, 2022 19:41
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 14, 2022
@hanzei hanzei added this to the v0.10.0 milestone Oct 14, 2022
@hanzei hanzei merged commit 82c78f1 into master Oct 14, 2022
@hanzei hanzei deleted the lint_update branch October 14, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants