Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MessageHasBeenDeleted hook #159

Closed
wants to merge 2 commits into from

Conversation

mickmister
Copy link
Contributor

Summary

Created to test mattermost/mattermost#22476

Ticket Link

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.39 ⚠️

Comparison is base (4c2db49) 18.16% compared to head (c753601) 17.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage   18.16%   17.78%   -0.39%     
==========================================
  Files          15       15              
  Lines        1679     1715      +36     
==========================================
  Hits          305      305              
- Misses       1333     1369      +36     
  Partials       41       41              
Impacted Files Coverage Δ
server/message_hooks.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mickmister
Copy link
Contributor Author

Closing in favor of #166

@mickmister mickmister closed this Aug 29, 2023
@hanzei
Copy link
Contributor

hanzei commented Aug 30, 2023

@mickmister I'm confused. This PR exercises MessageHasBeenDeleted and #166 exercises UserHasBeenDeactivated. Should we keep both open?

@mickmister
Copy link
Contributor Author

@hanzei Indeed I got mixed up. Too many hooks being added at once and related PRs 🙂

@mickmister mickmister reopened this Aug 30, 2023
@hanzei
Copy link
Contributor

hanzei commented Sep 26, 2023

Closing as #165 has been merged

@hanzei hanzei closed this Sep 26, 2023
@hanzei hanzei deleted the message-has-been-deleted-hook branch September 26, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants