Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid parameter for openInteractiveDialog #176

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Fix invalid parameter for openInteractiveDialog #176

merged 1 commit into from
Sep 1, 2024

Conversation

kaakaa
Copy link
Contributor

@kaakaa kaakaa commented May 8, 2024

Summary

This PR fix the issue that interactive dialog opened from main menu doesn't work fine.

screen.webm

Ticket Link

N/A

@kaakaa kaakaa requested a review from hanzei as a code owner May 8, 2024 13:35
@mattermost-build
Copy link
Contributor

Hello @kaakaa,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

hanzei
hanzei approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@hanzei hanzei requested a review from larkox July 4, 2024 08:47
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester and removed Lifecycle/1:stale labels Jul 4, 2024
larkox
larkox approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@larkox larkox removed the 2: Dev Review Requires review by a core committer label Jul 4, 2024
@larkox
Copy link
Contributor

larkox commented Jul 4, 2024

@hanzei Who should we assign here as QA reviewer?

@hanzei
Copy link
Contributor

hanzei commented Jul 4, 2024

That would be @DHaussermann

@hanzei hanzei requested a review from DHaussermann July 4, 2024 09:00
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@larkox
Copy link
Contributor

larkox commented Jul 22, 2024

@DHaussermann Friendly reminder on this.

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@larkox
Copy link
Contributor

larkox commented Aug 8, 2024

@DHaussermann Friendly reminder on this

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@larkox
Copy link
Contributor

larkox commented Aug 19, 2024

@DHaussermann Friendly reminder on this

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hanzei
Copy link
Contributor

hanzei commented Sep 1, 2024

Let's merge this as it is

@hanzei hanzei merged commit afb65b5 into mattermost:master Sep 1, 2024
6 checks passed
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed Lifecycle/1:stale 3: QA Review Requires review by a QA tester labels Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkox larkox larkox approved these changes

@hanzei hanzei hanzei approved these changes

@DHaussermann DHaussermann Awaiting requested review from DHaussermann

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaakaa @mattermost-build @larkox @hanzei