Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Interactive Dialogs example #28

Merged
merged 20 commits into from
Jun 22, 2019
Merged

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Apr 29, 2019

This PR adds two examples for Interactive Dialogs:

On cancel a message is posted in the channel.

Fixes mattermost/mattermost#10286

@hanzei hanzei added the 1: PM Review Requires review by a product manager label Apr 29, 2019
@hanzei hanzei requested a review from jasonblais April 29, 2019 15:20
@hanzei
Copy link
Contributor Author

hanzei commented Apr 29, 2019

@jasonblais Please give this a first round of review.

Copy link
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick initial review. Looks good to me. Some minor proposed text adjustments

@hanzei
Copy link
Contributor Author

hanzei commented Apr 29, 2019

@jasonblais Just to be clear: All the texts are Copy&Past from https://docs.mattermost.com/developer/interactive-dialogs.html#example. Should they also be updated in the docs?

jasonblais added a commit to mattermost/docs that referenced this pull request Apr 29, 2019
@jasonblais
Copy link
Contributor

@hanzei Yes, I made an update for three of the texts for docs mattermost/docs@8c6f83d

Co-Authored-By: hanzei <16541325+hanzei@users.noreply.github.com>
@hanzei hanzei requested a review from jasonblais April 30, 2019 05:47
@jasonblais
Copy link
Contributor

@hanzei Apart from text, is there anything else you'd like me to PM review?

@hanzei
Copy link
Contributor Author

hanzei commented May 1, 2019

@jasonblais I update the command to show an help.
Screenshot from 2019-05-01 16-57-58

Apart from text, is there anything else you'd like me to PM review?

Basically: Is the dialog working as you thought it would? Might be a good time to check if Interactive Dialogs work as designed.
But nothing special to look at.

Please note that a message is shown in chat when you cancel the dialog.

@jasonblais
Copy link
Contributor

@hanzei Would you be open to sharing a binary for demo plugin that I can use for testing?

@hanzei
Copy link
Contributor Author

hanzei commented May 1, 2019

@jasonblais Sure. Will send your a DM.

@jasonblais
Copy link
Contributor

jasonblais commented May 4, 2019

This is looking great. Will make testing significantly easier.

1 - I received a JavaScript error when enabling the plugin you shared. May or may not be related to the changes on this PR.

image

2 - Would prefer there was an output posted which we already discussed in the GitHub issue. For now, we can just post an output of all the provided information except the email address.

3 - Propose including a reference in README, so that developers and QA are aware of this being available. Further details about interactive dialogs can be directed to https://docs.mattermost.com/developer/interactive-dialogs.html.

4 - Finally, a crash occurs with /dialog no-elements. This is expected until mattermost/mattermost-webapp#2726 is merged.

jasonblais and others added 2 commits May 5, 2019 08:06
Co-Authored-By: hanzei <16541325+hanzei@users.noreply.github.com>
@hanzei
Copy link
Contributor Author

hanzei commented May 5, 2019

  1. I'm fairly confident that the errors are not related to this PR.
  2. Fixed. The message now looks like this:
    Screenshot from 2019-05-05 11-00-43
  3. Sure, will do.
  4. I'm fine with keeping this PR open, until MM-15128 - add support for interactive dialogs with no elements mattermost-webapp#2726 has been merged.

@mattermod
Copy link
Contributor

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @hanzei

@hanzei hanzei added the Work In Progress Not yet ready for review label May 22, 2019
@jasonblais
Copy link
Contributor

@hanzei That's okay for me if it's valuable to developers

@hanzei
Copy link
Contributor Author

hanzei commented Jun 13, 2019

@jasonblais Moved the images to docs/dialog.md. Please take a second look.

Copy link
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hanzei, just one text update proposal

Co-Authored-By: Jason Blais <13119842+jasonblais@users.noreply.github.com>
@hanzei hanzei requested a review from jasonblais June 13, 2019 18:25
@jasonblais
Copy link
Contributor

Thanks @hanzei 👍

@hanzei hanzei added 2: Dev Review Requires review by a core committer and removed 1: PM Review Requires review by a product manager labels Jun 13, 2019
@hanzei hanzei requested review from crspeller and levb June 13, 2019 19:46
@hanzei
Copy link
Contributor Author

hanzei commented Jun 13, 2019

cc @scottleedavis If you have feedback about this PR, feel free to share it.

@hanzei hanzei added this to the v0.2 milestone Jun 19, 2019
@hanzei
Copy link
Contributor Author

hanzei commented Jun 19, 2019

@levb @crspeller Gentle reminder to review this PR. Because it touches a lot of code, I would merge it rather sooner then later. Feel free to request a review from someone else, if you are to busy.

Copy link
Member

@crspeller crspeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have an example of this.

@hanzei hanzei requested review from alifarooq0 and removed request for levb June 21, 2019 13:44
@hanzei
Copy link
Contributor Author

hanzei commented Jun 21, 2019

Switching to @ali-farooq0 as a reviewer because of the changed responsibilities.

@alifarooq0
Copy link

I see that you've added the example to https://docs.mattermost.com/developer/interactive-dialogs.html#example
are there any plans to update https://developers.mattermost.com/integrate/examples/ to include the interactive example there?

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jun 22, 2019
@hanzei hanzei merged commit d27ced5 into master Jun 22, 2019
@hanzei hanzei deleted the MM-14185_interactive-dialogs branch June 22, 2019 04:59
@hanzei
Copy link
Contributor Author

hanzei commented Jun 22, 2019

are there any plans to update developers.mattermost.com/integrate/examples to include the interactive example there?

IMO the page is outdated and the list of integrations very selective. I would rather rework this whole page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MM-14185] Demo plugin: illustrate interactive dialogs
6 participants