Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend /dialog command to demonstrate generic error message in interactive dialog #66

Merged
merged 4 commits into from
Sep 18, 2019
Merged

Extend /dialog command to demonstrate generic error message in interactive dialog #66

merged 4 commits into from
Sep 18, 2019

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Sep 11, 2019

Summary

Extended /dialog command to demonstrate generic error message in interactive dialog

See mattermost/mattermost-webapp#3618

@hanzei hanzei added the Work In Progress Not yet ready for review label Sep 11, 2019
@hanzei hanzei force-pushed the dialog_error branch 2 times, most recently from 46b72ba to 6164c60 Compare September 11, 2019 20:01
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester and removed Work In Progress Not yet ready for review labels Sep 11, 2019
@hanzei hanzei requested a review from prapti September 11, 2019 20:24
@hanzei hanzei added this to the v0.3 milestone Sep 11, 2019
lieut-data
lieut-data requested changes Sep 12, 2019
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a question about the minimum server version change.

@hanzei hanzei requested a review from lieut-data September 12, 2019 13:57
alifarooq0
alifarooq0 reviewed Sep 16, 2019
View reviewed changes
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Sep 17, 2019
prapti
prapti approved these changes Sep 17, 2019
View reviewed changes
Copy link

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generic error shows as expected.
Approving.

@prapti prapti removed the 3: QA Review Requires review by a QA tester label Sep 17, 2019
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Sep 18, 2019
@hanzei hanzei merged commit c765cdf into master Sep 18, 2019
@hanzei hanzei deleted the dialog_error branch September 18, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prapti prapti prapti approved these changes

@lieut-data lieut-data lieut-data approved these changes

@alifarooq0 alifarooq0 alifarooq0 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hanzei @prapti @lieut-data @alifarooq0