Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define maintainer #97

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Define maintainer #97

merged 1 commit into from
Apr 7, 2020

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Apr 2, 2020

Summary

Example PR for adding a CODEOWNERS files and mentioning the maintainer in README.md.

Ticket Link

https://community-release.mattermost.com/core/pl/s59on6wz6tyufj8yy448yti3bo

@hanzei hanzei added the Work In Progress Not yet ready for review label Apr 2, 2020
@codecov-io
Copy link

codecov-io commented Apr 2, 2020 •
edited
Loading

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   16.11%   16.11%           
=======================================
  Files          13       13           
  Lines        1179     1179           
=======================================
  Hits          190      190           
  Misses        950      950           
  Partials       39       39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41cdbe5...6b7493f. Read the comment docs.

@hanzei hanzei added 2: Dev Review Requires review by a core committer and removed Work In Progress Not yet ready for review labels Apr 4, 2020
@hanzei hanzei requested review from jfrerich and levb April 4, 2020 10:32
jfrerich
jfrerich approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I haven't seen the CODEOWNERS file in a github repo before. I see you added a new column in the Integrations Process spreadsheet and will add the file and Maintainer mentions in my other owned repos.

@hanzei
Copy link
Contributor Author

hanzei commented Apr 6, 2020

Me neither. It's the first time I use it.

Would you mind waiting with adding the file to other repos util we discussed this PR in the meeting tomorrow?

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request Do Not Merge Should not be merged until this label is removed and removed 2: Dev Review Requires review by a core committer labels Apr 7, 2020
@hanzei hanzei removed the Do Not Merge Should not be merged until this label is removed label Apr 7, 2020
@hanzei hanzei merged commit 4a5a48f into master Apr 7, 2020
@hanzei hanzei deleted the maintainer branch April 7, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levb levb levb approved these changes

@jfrerich jfrerich jfrerich approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanzei @codecov-io @levb @jfrerich