Use ReactDOM webpack external #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 28.48% // Head: 28.48% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #318 +/- ##
=======================================
Coverage 28.48% 28.48%
=======================================
Files 20 20
Lines 2619 2619
=======================================
Hits 746 746
Misses 1789 1789
Partials 84 84 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
catalintomai
approved these changes
Sep 21, 2022
spirosoik
approved these changes
Sep 23, 2022
mickmister
added a commit
that referenced
this pull request
Oct 28, 2022
mickmister
added a commit
that referenced
this pull request
Oct 31, 2022
* Use ReactDOM webpack external (#318) * bump version 1.5.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This plugin currently doesn't use
react-dom, but I'm adding this here in case we add a library likereact-selectin the future.Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-47046