Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.9.0 #448

Closed
wants to merge 3 commits into from
Closed

Release 1.9.0 #448

wants to merge 3 commits into from

Conversation

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.02%. Comparing base (53b10f3) to head (9450e86).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #448   +/-   ##
=======================================
  Coverage   34.02%   34.02%           
=======================================
  Files          22       22           
  Lines        4021     4021           
=======================================
  Hits         1368     1368           
  Misses       2515     2515           
  Partials      138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jan 25, 2024
@hanzei hanzei added this to the v1.8.1 milestone Jan 25, 2024
@mickmister mickmister changed the title Release 1.8.1 Release 1.9.0 Jan 25, 2024
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Feb 6, 2024
@ayusht2810
Copy link
Contributor

@mickmister resolved merge conflicts and updated the description of the PR.

@AayushChaudhary0001
Copy link

While testing this PR, it was found that #278 was not fixed and is not working as expected.

@ayusht2810
Copy link
Contributor

@mickmister Can you please tell us how we can test the #278 issue for the plugin, as I think we may need to update the server version and min server version to have that feature supported?

@ayusht2810
Copy link
Contributor

@mickmister, a reminder regarding the above comment.

Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayusht2810 Since these changes are in Mattermost repo and the PR is merged on master, still there is no official release of Mattermost which contains this PR changes. Although, it has been tested locally and the changes work fine. Approving this PR.

@mickmister
Copy link
Contributor Author

Closing as we are doing releases with no version bumps now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants