Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-57194] Mark confidential settings as secrets #1118

Merged
merged 2 commits into from
Oct 1, 2024
Merged

[MM-57194] Mark confidential settings as secrets #1118

merged 2 commits into from
Oct 1, 2024

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Sep 13, 2024

@hanzei hanzei requested a review from wiggin77 as a code owner September 13, 2024 07:32
@hanzei hanzei requested a review from ayusht2810 September 13, 2024 07:37
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Sep 13, 2024
wiggin77
wiggin77 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanzei
Copy link
Collaborator Author

hanzei commented Sep 23, 2024

@ayusht2810 Gentle reminder to review the PR

@hanzei hanzei requested review from AayushChaudhary0001 and removed request for ayusht2810 September 27, 2024 07:24
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Sep 27, 2024
AayushChaudhary0001
AayushChaudhary0001 approved these changes Oct 1, 2024
View reviewed changes
Copy link

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR has been tested for the webhook secret which gets encrypted in plugin configs, LGTM. Approved

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Oct 1, 2024
@hanzei hanzei merged commit 1ff05f7 into master Oct 1, 2024
9 checks passed
@hanzei hanzei deleted the MM-57194_support-packet_plugin-secrets branch October 1, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AayushChaudhary0001 AayushChaudhary0001 AayushChaudhary0001 approved these changes

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

@wiggin77 wiggin77 wiggin77 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanzei @wiggin77 @raghavaggarwal2308 @AayushChaudhary0001