-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mm-604] - ability to create a subscription template #783
Conversation
Hello @maisnamrajusingh, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
Codecov Report
@@ Coverage Diff @@
## master #783 +/- ##
==========================================
- Coverage 31.42% 30.76% -0.67%
==========================================
Files 49 49
Lines 5982 6104 +122
==========================================
- Hits 1880 1878 -2
- Misses 3913 4036 +123
- Partials 189 190 +1
Continue to review full report at Codecov.
|
@aaronrothschild @matthewbirtch Please see the video attached in the PR description. Currently it looks like the feature works this way:
@maisnamrajusingh Are the subscriptions scoped to a given channel or team? If possible, we should filter on Jira projects the current user has access to. |
@mickmister do you know if any design work was done for this feature? I don't see anything done in our Figma files yet and I don't see a Figma link in the description here. I think the design team might need to take a pass at this to clean up the design/layout a bit. |
@matthewbirtch I don't think there's been any design for the feature, which was an oversight on creating the help wanted ticket. I'll discuss with the team how we can make sure design decisions are taken care of before opening the ticket for development. What would be next steps to get this feature under design review? |
Hey, @mickmister, it would be helpful to know the use cases and requirements for this feature. |
I'll keep these use cases on this ticket:
Requirements:
|
@andrewbrown00 Our internal use case is that some of our Jira tickets are internal, and so we need to make sure all of the subscriptions going to public channels have these tickets filtered out. With this ticket implemented, we can have a baseline for a "safe" subscription to be reused among several users. This avoids user error that may expose sensitive information. We can then open up the feature to more users, since community currently has the feature locked to system admins. The subscription template is identical to an actual subscription, except it doesn't actually process any webhook events, and it's not associated with any specific channel. It does need to adhere to every rule of subscriptions, meaning it needs to be scoped to a specific Jira project, and the user configuring the subscription needs to have access to that project in Jira. |
@mickmister @aaronrothschild @andrewbrown00
From my initial view, here are some thoughts. Happy to have more of a discussion here. Overall
Add Jira Subscription Screen
Subscriptions and Templates List Screen
Anyway, that's my first pass. As mentioned, I can try to devote some time to mocking this up (or finding another member of the team to do so) if it would be helpful |
@matthewbirtch @andrewbrown00 I have two cloud servers set up for testing this. The first link is running the current release of the Jira plugin, and the second has this PR deployed. Access the feature by running https://jira-plugin.test.mattermost.cloud |
@matthewbirtch Thanks for all the detailed feedback! The channel subscriptions feature was developed a while ago and hasn't been revisited for some time. Reading through your comment, I agree that the overall flow of the feature can be improved, even outside of this PR's scope. The subscription template feature may need to put on hold if the redesign/reimplementation of the subscriptions feature needs to occur first, since that should be a separate PR from introducing the templates depending on how big the changes are. |
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
@matthewbirtch Would you like to have a video call to discuss this feature? If you'd like to test the feature yourself, please see the spinwick URLs posted here #783 (comment) |
@mickmister I think that would likely be a good idea. Once we do that, we should probably this up for design to work through before developing further. Can we set something up with you, me @andrewbrown00 and @aaronrothschild? |
@mickmister @matthewbirtch how did it go ? |
@mickmister Can you expand on the use case for security of the templates? I think it would be fine for us to start with no access control for particular templates and perhaps add it later if requested/needed. I understand that we'd want to follow your advice for now perhaps and show subscriptions based on Project to make it easier/possible in the future to have access control. |
@aaronrothschild I think leaving out access control for browsing the templates is fine, though we should still require the user to be a member of the project before editing or creating a template for a project they don't have access to. There is already similar code for access control around subscriptions so this should be straightforward. |
@maisnamrajusingh Is this PR review for review? |
@hanzei no not yet. Currently prioritizing the jira ones. |
Closing in favor of #897 |
Summary
A UI to create a subscription template. Please check the video below for details.
https://www.loom.com/share/f988879135c54d789f4bd015b207e9d8
Ticket Link
#604