Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix DEFAULT_* handling #1941

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix DEFAULT_* handling #1941

merged 1 commit into from
Sep 11, 2024

Conversation

lieut-data
Copy link
Member

Summary

We added DEFAULT_GOOS and DEFAULT_GOARCH a while back so it was easy to cross compile for a quick deploy, e.g.:

export MM_SERVICESETTINGS_ENABLEDEVELOPER=true 
export MM_DEBUG= 
export DEFAULT_GOOS=linux 
export DEFAULT_GOARCH=amd64 
make dist

Somehow or another, this was just done wrong. I need to fix this "upstream" in the starter template too.

Ticket Link

None

@lieut-data lieut-data added the 2: Dev Review Requires review by a core committer label Sep 9, 2024
@lieut-data lieut-data marked this pull request as ready for review September 9, 2024 16:18
@lieut-data lieut-data added QA Deferred 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Sep 11, 2024
@lieut-data lieut-data merged commit bb6dbf8 into master Sep 11, 2024
15 checks passed
@lieut-data lieut-data deleted the fix_default_handling branch September 11, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienTant JulienTant JulienTant approved these changes

@sbishel sbishel sbishel approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request QA Deferred
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lieut-data @JulienTant @sbishel