Add participant modal footer alignment fix #1949
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Aryakoste, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
mattermost-build
requested review from
a team and
crspeller
and removed request for
a team
mattermost-build
added
2: Dev Review
|
This type of alignment issue is also occuring in other modals. Because the modal-footer is flex and the first element is :before content. I can make the change in generic modal if needed.
|
|
First the width 100% was not working i think it was not compiled properly now its working so changed to that. |
crspeller
requested review from
a team,
devinbinnie and
lindy65
and removed request for
a team
crspeller
approved these changes
Oct 23, 2024
lindy65
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Thanks @Aryakoste 🙌
cc @crspeller - this will need to be tested post merge once a new version of playbooks is cut
lindy65
added
QA Deferred
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
Fixes mattermost/mattermost#27537
Jira https://mattermost.atlassian.net/browse/MM-58182
Before Screenshot:-
After Screenshot:-
Checklist
- [ ] Telemetry updated- [ ] Gated by experimental feature flag- [ ] Unit tests updated