Add a link to the project status page on CircleCI #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
reviewed
Sep 3, 2019
|
This issue has been automatically labelled "stale" because it hasn't had recent activity. /cc @jasonblais @hanzei |
|
@tnir If you don't mind I will do the proposed changes and then merge. |
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
tnir
force-pushed
the
better-circleci-badge
branch
from
c02fd7c
to
03ef7a0
Compare
tnir
changed the title
hanzei
approved these changes
Sep 19, 2019
|
@tnir Please merge |
hanzei
approved these changes
Sep 19, 2019
Co-Authored-By: Ben Schumacher <ben.schumacher@mattermost.com>
alifarooq0
approved these changes
Sep 20, 2019
|
@hanzei Thanks for the comment. Adpated thr suggestion. |
|
@tnir if you merge |
hanzei
added
4: Reviews Complete
|
Thanks @ali-farooq0 Was able to confirm all tests on CI passed at https://github.com/mattermost/mattermost-plugin-starter-template/runs/229404880 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids to use shields.io's badgecf. some usecase in a certain project: wbernest/mattermost-plugin-rssfeed#18