Searchable teams filter #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshilsharma63
commented
Nov 21, 2024
| const initialFilterTypeValue = savedSetting?.filterType || 'everyone'; | ||
| setTeamFilterType(initialFilterTypeValue); | ||
| // fetch selected teams | ||
| const teams = await getTeamsByIds(savedSetting.filteredTeamIDs); |
There was a problem hiding this comment.
I know this can make many API calls all together, but this would be once, in a very in-frequently accused part of the app.
harshilsharma63
added
2: Dev Review
yasserfaraazkhan
approved these changes
Nov 21, 2024
M-ZubairAhmed
approved these changes
Nov 21, 2024
| // fetch all teams to populate options | ||
| const teams: Team[] = await Client4.getTeams(0, 10000, false) as Team[]; | ||
| // getTeams always returns Team[] when includeTotalCount param is set to false | ||
| const teams = await Client4.getTeams(0, 20, false) as Team[]; |
There was a problem hiding this comment.
is this standard way of doing this in this repo. In web we usually have an action.
There was a problem hiding this comment.
Yes, this is how we do it in simple plugins, like this one.
| const initialFilterTypeValue = savedSetting?.filterType || 'everyone'; | ||
| setTeamFilterType(initialFilterTypeValue); | ||
| // fetch selected teams | ||
| const teams = await getTeamsByIds(savedSetting.filteredTeamIDs); |
There was a problem hiding this comment.
if getTeamsByIds is only used in this useEffect then cant we define it in this closure itself? 0/5
larkox
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated team filter dropdown to search all teams on server.
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-61902