-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Apple APNS AuthKey #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great Elias. Just some small suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superb work 👌
@spirosoik friendly reminder to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work thanks @enahum
@spirosoik @stylianosrigas the current apple certificate will expire in the next 30 days, this PR has been sitting here for a long while now, I'll be back from PTO on the 14th of April, can we coordinate so that this PR gets merged and deployed to our HPNS and TPNS as well as start using the API keys instead of the certs. The benefit of doing that is that we won't need to deploy updated certs every year. The one downside would be that we would need to rotate the API in case there is a security breach of some sort. Note: The previous method of using the cert is still valid after this PR gets merged and deployed |
@enahum Sounds good to me. Once we merge and cut a release, SRE Team can work on updating the Push Proxy helm chart and deploy where needed in cloud. |
With the introduction of APNS auth key (#101), there is no need to renew certs any more. We clean it up.
With the introduction of APNS auth key (#101), there is no need to renew certs any more. We clean it up.
Summary
This PR adds support for Apple AuthKey with this we will be using the same key for all Apple topics (one per-app) which means that the same key will WORK with every app we ship, also this removes the need to having to renew certificates every year. Also for customers the setup for APN is going to be much easier than the current certificate conversion to PEM.
Ticket Link
N/A