This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-14500 Fix for pop caused by size_aware_image #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
enahum
approved these changes
Mar 8, 2019
sudheerDev
added
Work in Progress
|
Need a minor css change |
sudheerDev
added
2: Dev Review
sudheerDev
force-pushed
the
MM-14500
branch
2 times, most recently
from
9d7d61a to
d5d126c
Compare
sudheerDev
added
2: Dev Review
|
@hmhealey Up for review. |
…sts (mattermost#2334) * MM-13099 Use size_aware_image component for all instances for loading images in webapp. * Removing getFileDimensionsForDisplay in favour of SizeAwareImage as it would be reliable in preventing scroll pop * Add a fallback for svg as older version do not have dimentions MM-14500 Fix for pop caused by size_aware_image * Use svg for creating placeholder instead of canvas and dataUrl Change to inline-block for hover css shadow effect Add defensive check for dimensions Removing display: inline-flex as it causes svg in the placeholder to not take the available space Have to move border hioghlight to img tags as div is display block by default so shows border for the entire box instead of just the image Update snapshots and fix lint
hmhealey
reviewed
Mar 12, 2019
hmhealey
approved these changes
Mar 20, 2019
amyblais
added
Changelog/Not Needed
stevepartridge
pushed a commit
to stevepartridge/mattermost-webapp
that referenced
this pull request
Mar 30, 2019
* MM-13099 Use size_aware_image component for when loading images in posts (mattermost#2334) * MM-13099 Use size_aware_image component for all instances for loading images in webapp. * Removing getFileDimensionsForDisplay in favour of SizeAwareImage as it would be reliable in preventing scroll pop * Add a fallback for svg as older version do not have dimentions MM-14500 Fix for pop caused by size_aware_image * Use svg for creating placeholder instead of canvas and dataUrl Change to inline-block for hover css shadow effect Add defensive check for dimensions Removing display: inline-flex as it causes svg in the placeholder to not take the available space Have to move border hioghlight to img tags as div is display block by default so shows border for the entire box instead of just the image Update snapshots and fix lint * Fix review comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes scroll pop caused by size_aware_Image component
screenshots with breakpoint onMount
Before
After
Ticket Link
MM-14500
MM-14637
MM-13908
MM-13158
MM-13930
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed